Issue263 : Added model filter in neighbordb #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlobato
reviewed
Apr 15, 2024
dlobato
force-pushed
the
issue263_model_filter
branch
from
ab213e1 to
cb726b6
Compare
dlobato
reviewed
May 1, 2024
dlobato
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Like some other people asked for, we needed to filter definitions by switch model. In our case, it was for EOS version compatibility with older switches.
We tried to add the feature in this small patch. This allow to add a "model" parameter in the neighbordb patterns, as a regular expression.
We're actually running our forked version in production, and everything seems fine.
We also added information about this filter in the "documentation" section.
Christophe and Alain
University of Strasbourg (FR)